Yeezy

Hey, Just wondering if anyone managed to replicate or set the "status" rp key using node-steam, just like FiveM seems to do on sourcemod, not sure if this is possible either currently with node-steam

https://partner.steamgames.com/doc/api/ISteamFriends#SetRichPresence

https://github.com/citizenfx/fivem/blob/88a0a6c5490f98c31ffdd56b565ac2f21fdfe523/code/components/steam/src/SteamComponent.cpp#L639

// doesn't work
client.setPersona(SteamUser.EPersonaState.Online)
client.gamesPlayed(218) // Source Mod 2007
client.uploadRichPresence(218, { "status": "FiveM?"})

// works but not what I'm trying to achieve
client.setPersona(SteamUser.EPersonaState.Online)
client.gamesPlayed(440) // TF2
client.uploadRichPresence(440, {
  "steam_display": "#tf_richpresence_display",
  "state": "PlayingGeneric",
  "currentmap": "FiveM?"
})

When calling the method logOff(), it automatically reconnects,

Possibly something wrong with line 53 in connection.js?

since it believes its not loggingOff it will reconnect automatically when autoRelogin is enabled even though it was called from the logOff method.
as for a quick dev test, forcing this value to true instead of false seems to fix it but ofc will break it when it tries to reconnect if it goes down due to steam downtime

4.28.4 still leaked memory unfortunately.

Running a test currently with the following handlers disabled:

EMsg.ClientPersonaState
EMsg.ClientClanState
EMsg.ClientFriendsList

It's been looking good so far no memory leak yet (running for 4+ days now)
 

Seems like I acted too soon, but its still weird behavior

Ignore the RSS size, its caused by the heapsnapshot not being released properly (https://github.com/nodejs/node/issues/44027)

I don't have a snapshot from when the server was initialized but I have one from a server that was started at the exact same time and has the same amount of steamUser instances on it.

If there's anything specific you'd like me to try and/or look at please let me know.

no leak:

leaked:

Node: v16.14
[email protected]

Should I run node LTS 18.x and see if that resolves anything?
or log a specific variable/obj count inside the module to see whats happening?

I took a heap snapshot and will be checking it, I'll post an update if I find anything

14 hours ago, Dr. McKay said:

Between your two screenshots, it kinda looks to me like g_ProcessPersonaSemaphore is somehow hanging at some point. The semaphore is backed by a linked list, and I see a lot of prev pointers in your OP screenshot. I don't really see why it would hang though, all code paths end in releasing the lock. That would also cause SteamID objects to pile up, as you're seeing in your heap snapshot.

In any case, try 4.28.4 and see if that fixes things for you.

Thank you, I'll try the update and let you know

15 May, Heapsnapshot size: 71 MB (no leak)

16 May, Heapsnapshot size: 1.85 GB

Should I log/trace all locations where a new SteamID gets created (inside the node-steam-user lib) and see if that leads me anywhere?

There's a possible memory leak in comps/friends.js or comps/familysharing.js
(edit: I could be wrong about where the leak is)
(please check my attached image)

The issue is rare and I'm unable to actively reproduce it yet, However it happens every 7 to 14 days after the App has been running for a while with 150~ instances of steamUser. (no memory leak until it happens)

 I will update this thread as I find more useful details to go on.

the only part of my code which interacts with the steamUserFriends

    steamUser.chat.on('friendMessage', async (message) => {
        if (config.autoReply) {
            if (!client.autoReplyRecipients.includes(message.steamid_friend.getSteamID64())) {
                client.autoReplyRecipients.push(message.steamid_friend.getSteamID64())
                steamUser.chat.sendFriendMessage(message.steamid_friend, config.autoReply)
                setTimeout((removeSteamId) => {
                    client.autoReplyRecipients = client.autoReplyRecipients.filter(steamId => steamId !== removeSteamId)
                }, 60000, message.steamid_friend.getSteamID64())
            }
        }
    })

    steamUser.on('friendRelationship', (sid, relationship) => {
        if (config.autoFriend && relationship == SteamUser.EFriendRelationship.RequestRecipient) {
            steamUser.addFriend(sid)
        }
    })

Hello,

I was messing around with the UIMode status and saw that VR was missing,

This file hasn't been touched since 1 Jun 2016 so I also assume you haven't revised it or looked into it at a later given time?

I was wondering if you could revisit it and perhaps add it if possible?

Thank you regardless,

https://github.com/DoctorMcKay/node-steam-user#setuimodemode