Missing newOffer events

[kryo]

I've noticed that on occasion (happens every 30 or so offers) I don't receive a newOffer event, the offer is simply forgotten about and eventually canceled automatically. Interestingly, if I send another offer right away (before the first one is canceled) I get a newOffer event for both of them.

I've only just started noticing this bug, using version 1.19.0: https://github.com/kryogenic/node-steam-tradeoffer-manager/tree/v1.19

[Dr. McKay]

newOffer isn't emitted for sent offers.

 

Also, please update to the latest version.

[kryo]

Ok I did a rm -rf node_modules/ and updated my package.json dependencies as follows:

    "steam-tradeoffer-manager": "github:DoctorMcKay/node-steam-tradeoffer-manager",
    "steam-user": "github:kryogenic/node-steam-user",
    "steamcommunity": "^3.19.1",

Seems to have solved the issue. Thanks.

 

While testing this issue I found that if you send an offer too quickly after initializing the manager it will show up as unknownOfferSent instead of the expected sentOfferChanged. On further inspection the offer id in the poll data seems to have increased by about 50.

[Dr. McKay]

Deploying from GitHub is a bad idea; use npm instead.