Lagg Posted August 17, 2016 Report Share Posted August 17, 2016 Essentially it appears `p` in the query string in /inventoryhistory is blacklisted and will unconditionally error out. Just with this hilariously enough. ?foobar22=1 is fine. It looks like they're doing something more or less like primary key-based paging now with after_time and after_trade. Which must be interesting on their end sorting-wise. Also the pagination stat regexps are no longer valid because they apparently no longer exist as such. So fix-wise I guess remove the regexp lines and avoid using the properties. Also remove "&p=" + options.page from inventoryhistory.js. These things appear to be the only breaking changes. No actual markup changed beyond that inner text. Which was nice of them I suppose. Overall an interesting strategy of load reduction on Valve's part. I must say. Quote Link to comment Share on other sites More sharing options...
Dr. McKay Posted August 17, 2016 Report Share Posted August 17, 2016 I've created a GitHub issue for this, as the module does need to be updated. I'm unsure when I'll have time to get to it, but it should be soon. If anyone relies heavily on this, I can prioritize it. Quote Link to comment Share on other sites More sharing options...
BOSS KONG Posted August 26, 2016 Report Share Posted August 26, 2016 My bots rely very heavily on this method (allows me to confirm item deposits without the need for my bots to have an API key). I spent a good 15 minutes wondering why I was receiving an error on every single attempt. Any update to the module that will allow me to use this as before without a work-around would be greatly appreciated. Quote Link to comment Share on other sites More sharing options...
Lagg Posted August 31, 2016 Author Report Share Posted August 31, 2016 Remove the &p= part from the URL in components/inventoryhistory.js as well as the code that tries to capture the pagination data (which will lead to an undefined reference otherwise). This will however result in losing that metadata and only getting the first page unless you want to add logic for after_trade. Naturally this qualifies as a workaround and is probably not as clean as what the upstream fix will look like. But until there's something pushed don't know what else to tell you :/ Quote Link to comment Share on other sites More sharing options...
Dr. McKay Posted September 1, 2016 Report Share Posted September 1, 2016 v3.24.0 adds support for the new pagination mechanism. How to use it is kinda confusing now.... If anyone has questions after reading the new documentation, please feel free to ask here. Quote Link to comment Share on other sites More sharing options...
Recommended Posts
Join the conversation
You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.