Dr. McKay

If you're going to lower the max items value, I would also configure a dataDirectory so that excess items can be stored locally on the disk instead of having to consult Steam every time. Performance shouldn't be impacted too heavily, but it may be noticeable. You'll definitely minimize your impact by configuring a dataDirectory.

This is already done in the module via persisting to local disk with the dataDirectory option (which you can redirect to go anywhere you want, including MongoDB). Update to v2.10.0 and you can override the maximum size of the asset cache, but beware that doing so will negatively impact performance as more and more items will need to be retrieved from the disk for every poll. In practice, for the best performance, you will need more RAM the more trades you make.

One of the descriptions will indicate if an item is uncraftable.

I suspect that you're having problems because you have two newOffer handlers. They will both fire, so you'll be trying to decline all offers that aren't sent by the owner, even if they should be accepted by your trading logic.

Oh yeah, it's an object. Object.keys(client.myFriends).filter(steamID => client.myFriends[steamID] == SteamUser.EFriendRelationship.Friend).length

client.myFriends.length

Unless you want to dive into the code and try to figure out what's wrong, you'll have to wait until I have time to look at it, which probably won't be anytime soon. Sorry.

I've added ban methods in v4.10.0.

The module itself is definitely supported. There are some deprecated methods and such, but only because newer things have replaced them. I did a test myself and I got about a half-second round-trip time, counting from when I hit enter and stopping when my bot responded to me. That doesn't seem unreasonable to me. I just haven't gotten around to adding a feature to ban people from a group chat yet. If that's something you need, I'll see if I can prioritize it.

I don't know why you would call this a "legacy module", but any lag is on your end. Either in your code, or in your connection to Steam.

Auth session tickets were never really tested. It's pretty likely that the code to retrieve and activate them doesn't work properly.

getPlayerCount is an asynchronous method. You need to either handle the Promise, or attach a callback (user.getPlayerCount(504370, function(err, count) { ... })). But you also need to wait for the loggedOn event before you do anything after calling logOn.

The first argument needs to be an enum value, not a string.

Games.join("\n")

No.

You're welcome to use the module by downloading it from Github, but that's ill-advised. You should be using npm install steam-user on the command line to download the library. But if you really really want to download from Github, you'll need to run npm install inside the module directory to download dependencies. Once you're logged on, you should be able to use user.getPlayerCount(...)

What version of steam-user do you have? Are you using the steamGuard event?

I still can't reproduce that. That shouldn't be possible, since the property gets initialized to 0 right before the loggedOn callback fires.

In general, Valve's GCs don't actually respond to messages using job IDs (which is the mechanism used when you pass a callback to sendToGC. Only if the GC supports using a message as a job will the callback be invoked. ClientHello is not a job-based message. Are you sure that ++this._currentGCJobID is returning NaN? I can't reproduce that on my end, and I see no way in the code that this would happen.

It's not part of node-steamcommunity anymore. You should use the WebAPI instead.

Run npm update and it will throw properly.

You're somehow passing a bool to two_factor_code in the logOn method.

Yep, that looks right. Although be aware that your callback function there is going to be called once for every item in your inventory that has a matching name. Put a return statement after the callback invocation to avoid that.

I would hazard a guess that badvar is not defined.

You have a misunderstanding of how asynchronous code works in JavaScript. You need to pass a callback to getID and call it with the item ID you're looking for.